Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use python 3.7+ syntax for action_helper.py #633

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Jul 14, 2022

With #629 merged in, action_helper.py can now use python 3.7+ syntax and undergo the same pre-commit checks as the rest of the code base.

@FollowTheProcess
Copy link
Collaborator

FollowTheProcess commented Jul 14, 2022

Happy with this, but if we merge right now will isort (and potentially pyupgrade) fail the lint step? Could you run pre-commit locally with the changes and then update the PR? Just so the main branch doesn't go "red" (even if temporary)

pre-commit run --all-files should do the trick

@mayeut
Copy link
Contributor Author

mayeut commented Jul 14, 2022

Happy with this, but if we merge right now will isort (and potentially pyupgrade) fail the lint step?

The lint step was run & successful as part of the PR.

The diffs you can see on action_helper.py are in fact the result of running pre-commit run -a locally.

@FollowTheProcess FollowTheProcess merged commit 4abf724 into wntrblm:main Jul 14, 2022
@mayeut mayeut deleted the action-helper-3.7 branch July 14, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants