chore: use python 3.7+ syntax for action_helper.py #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy with this, but if we merge right now will isort (and potentially pyupgrade) fail the lint step? Could you run pre-commit locally with the changes and then update the PR? Just so the main branch doesn't go "red" (even if temporary)
|
mayeut
force-pushed
the
action-helper-3.7
branch
from
6da8bdb to
0eec57d
Compare
The lint step was run & successful as part of the PR. The diffs you can see on action_helper.py are in fact the result of running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #629 merged in,
action_helper.pycan now use python 3.7+ syntax and undergo the same pre-commit checks as the rest of the code base.