fix(types): full strictness checking on mypy #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Apr 19, 2022
Comment on lines
-40
to
+43
| src.__globals__, # type: ignore[attr-defined] | ||
| src.__globals__, |
There was a problem hiding this comment.
These were fixed upstream in typeshed and included in mypy 0.94x.
| | str | ||
| | None | ||
| | list[str] | ||
| | Callable[[], bool | str | None | list[str]] = None, |
There was a problem hiding this comment.
This should probably be generic eventually - Option[str] would hold a str, etc. But didn't look into it.
henryiii
commented
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to (and includes) #595. Enabling full strictness checking for mypy and bumping the version of mypy (which removes a few ignores).
There are still two sets of ignores that can likely go away in the future. There are some around py.path that will go away with #592. There are also likely some related to function decorators - by properly typing decorators with generics, we can tighten that up and make those work better too (but that's a followup for some other time).
Closes #595 if this gets merged before that, since it contains that commit.