Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox-to-nox: support descriptions #575

Merged
merged 1 commit into from
Feb 17, 2022
Merged

tox-to-nox: support descriptions #575

merged 1 commit into from
Feb 17, 2022

Conversation

ktbarrett
Copy link
Contributor

Closes #574. I didn't see any tox-to-nox tests, but it's a small enough change to manually confirm.

@FollowTheProcess
Copy link
Collaborator

FollowTheProcess commented Feb 15, 2022

There are tox-to-nox tests in tests/test_tox_to_nox.py they're all fairly simple "tox file in, nox file out" type tests, should be easy enough. If we're going to merge this in we'd need a test please, otherwise this looks great 👍🏻

Edit: I've never actually used tox, can envname.description be a multi line string? If so we'd probably want to handle stripping extra whitespace etc.

@ktbarrett
Copy link
Contributor Author

tox allows multiline string and folds them into a single line.

@FollowTheProcess
Copy link
Collaborator

tox allows multiline string and folds them into a single line.

Cool! thanks

@FollowTheProcess
Copy link
Collaborator

@ktbarrett when you get a sec can you resolve the conflicts on this (it's just conflicting with your other change) and then we can get it merged in 👍🏻

@FollowTheProcess FollowTheProcess merged commit d15dde9 into wntrblm:main Feb 17, 2022
@FollowTheProcess
Copy link
Collaborator

Thanks @ktbarrett 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

tox-to-nox: make docstring from testenv description
2 participants