Fix current Conda env detection #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tolker-KU
force-pushed
the
feature/conda_currenct_env_detection
branch
from
a135fda to
af6a3c8
Compare
|
Lint job failed with a weird error. Can someone with permission try to re-run it? |
|
It seems GitHub actions is being a little spotty atm! |
Indeed! Also some timeout related fails on CI for this PR now: #537 |
|
Something similar happened at #526. That's weird. |
|
GHA is having an issue currently. |
cjolowicz
approved these changes
Dec 27, 2021
There was a problem hiding this comment.
LGTM
FTR #406 mentioned a few other things that we might be missing: the CONDA_DEFAULT_ENV variable, and custom activation scripts used by some packages. I'm fine with dealing with those other things if and when concrete use cases are reported for them. (In fact I think waiting is preferrable here as that'll give us better insight about how to solve this correctly.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #406.