chore: bump linting versions to latest #528
Conversation
henryiii
changed the title
|
(will collide with #527, but that's fine, that's a good update too :) ) |
| @@ -90,34 +90,36 @@ def cover(session): | |||
| session.run("coverage", "erase") | |||
|
|
|||
|
|
|||
| @nox.session(python="3.8") | |||
| black_pins = ["black==21.12b0", "isort==5.10.1"] | |||
There was a problem hiding this comment.
Something we can do is having the linting dependencies on a requirements file, and enable Dependabot updates? That way, we don't have to stay alert for PyPI updates, and we can focus on checking what Dependabot suggests. Remember that Dependabot will only change pinned versions.
There was a problem hiding this comment.
The two projects I know of using dependabot for Python (SciPy, manylinux) both dropped it gladly. I personally use it for actions updates, for which it works really well. I don't think I use it for Python anywhere, so I can't address why they didn't like it, though I think it partially was really finicky and not interested in accepting PRs to fix Python issues. I think pre-commit.ci is superior if you'd like to go that way. But not in this PR, I could whip up a pre-commit PR after this one if you'd like to see it.
|
(Sorry for my last strange review, I didn't read your post 😅). |
|
It seems that the Python version for lint and docs is pinned at 3.8 in CI. I guess that should be updated to 3.9 as well? |
|
Oops, sorry! Will fix. |
|
(In fact, I thought I did change this, but I guess it didn't stick) |
I've bumped the linting versions to latests, cleaned up the mypy updates, and bumped from Python 3.8 to Python 3.9.
Are you interested in moving to pre-commit + pre-commit.ci, perhaps? That would automate this process of bumping pins and would also help new contributors by automatically running the auto-fixes ("blacken") on PRs if you want it to. I'd apply the method described in https://scikit-hep.org/developer/style and used in pybind11, cibuildwheel, etc.