Add option --no-install to skip install commands in reused environments #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
Co-authored-by: Jam <jam@jamandbees.net>
|
LGTM, thanks! |
theacodes
reviewed
May 28, 2021
| @@ -320,6 +327,18 @@ def _session_completer( | |||
| group=options.groups["secondary"], | |||
| help="Re-use existing virtualenvs instead of recreating them.", | |||
| ), | |||
| _option_set.Option( | |||
| "R", | |||
There was a problem hiding this comment.
This should be lowercase, right?
There was a problem hiding this comment.
The option is uppercase (-R), so using r as the option name would lead to an error:
Traceback (most recent call last):
File ".../nox/venv/bin/nox", line 33, in <module>
sys.exit(load_entry_point('nox', 'console_scripts', 'nox')())
File ".../nox/nox/__main__.py", line 30, in main
args = _options.options.parse_args()
File ".../nox/nox/_option_set.py", line 267, in parse_args
self._finalize_args(args)
File ".../nox/nox/_option_set.py", line 255, in _finalize_args
value = getattr(args, option.name)
AttributeError: 'Namespace' object has no attribute 'r'Our option.name must match the name that argparse derives for the option. In this case, the option is uppercase -R with no equivalent long option, so argparse derives R as the option name.
theacodes
approved these changes
May 31, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option
--no-installto skip the re-installation of packages when a virtualenv is reused.Use either of these to reuse a virtualenv without re-installing packages:
The
--no-installoption causes the following session methods to return early:session.installsession.conda_installsession.run_alwaysThis option has no effect if the virtualenv is not being reused.
Closes #394
Supercedes #411
Co-authored-by: @jamandbees