Convert function decorators to class decorators #290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, sorry for the delay.
I have improved typing as discussed in #287. I have:
noxfile.py
to include the--warn-unused-ignores
flag._decorators
file, as the code started to call and inherit from multiple different files. This was causing some cyclical dependencies._parametrize.generate_calls
to a class decorator,Call
.registry.session_decorator
to delegate to a class decorator,Func
.manifest._copy_func
into_decorators
and call it inFunc
.manifest.Manifest.make_session
to useFunc.copy
rather thanmanifest._copy_func
.Call
subclassFunc
.# type: ignore
.Callable
toFunc
.Given the size of the existing PR I have decided to leave the typing of the attributes as is.