Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when programs not in the virtualenv are used, allow erroring and silencing the warning. #147

Merged
merged 1 commit into from
Oct 13, 2018

Conversation

theacodes
Copy link
Collaborator

Add --warn-on-external-run flag and the "external" keyword arg to session.run.

Closes #130

… silencing the warning.

Add --warn-on-external-run flag and the "external" keyword arg to session.run.
@theacodes
Copy link
Collaborator Author

@dhermes you don't have to review in you don't want to. This one was pretty trivial, but happy to hear any input you have.

@theacodes theacodes merged commit 908d82f into master Oct 13, 2018
@theacodes theacodes deleted the external-tools-are-bad-mmmkay branch October 13, 2018 04:35
if is_external_tool:
if external == "error":
logger.error(
"Error: {} is not installed into the virtualenv, it located at {}. "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it located -> it is located

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, 1646e52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

nox uses PATH to find executables
2 participants