Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nox.options which allows specifying command-line configuration in the Noxfile #145
Add nox.options which allows specifying command-line configuration in the Noxfile #145
Changes from all commits
ee48424
4716ed1
ad65a55
eb83dfd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When does this get verified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same place as the command-line arg, during
tasks.filter_manifest
->manifest.filter_by_name
. It'll barf if you pass garbage, ofc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any plans for checking if this goes stale? Something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're going to remain relatively conservative on adding new command line args (I say this as I'm writing a PR to add a new one...). I also don't have doctest setup yet, so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a bad reason?
But it's up to you. That was just a suggestion. You wouldn't get pretty CSS in a doctest. Or maybe it's possible, I just don't know how.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a great reason to never do it, but it's a good reason not to do it right now. We can file a bug and pick it up later. (e.g. perfect being the enemy of good here, especially for collateral like documentation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Feel free to file if you like the idea / if you want doctests. I love doctests and forbid
code-block:: python
in some projects (e.g.bezier
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a docstring? I'm mostly just unclear on the shape of
options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.nox
as default?formatter_class=argparse.ArgumentDefaultsHelpFormatter
will actually document your defaults so you don't need to write it in your proseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving
.nox
as default makes it impossible for me to tell if it was specified at the command line or not. Leaving it as "None" allows me to distinguish that, and the default assignment is moved intomerge_from_options
.