If X.Y-32 is used on non-Windows, just skip.
#138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
commented
Sep 19, 2018
| @@ -122,9 +122,11 @@ def _resolved_interpreter(self): | |||
|
|
|||
| Based heavily on tox's implementation (tox/interpreters.py). | |||
| """ | |||
| from nox.sessions import _SessionSkip | |||
There was a problem hiding this comment.
@theacodes I don't like this. It was to avoid a circular import since nox.sessions imports nox.virtualenv. What do you think we should do?
There was a problem hiding this comment.
Why not just raise a new InterpreterNotFound error? We could use that as a more general purpose solution to #93.
There was a problem hiding this comment.
Care to take the wheel here? I'm not really sure where to put it / what other corners to test it in.
|
I expected some tests to fail that verified the contents of the logged error message (which were previously in |
|
For posterity, this was closed in favor of #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136.