Add tests #2
Merged
Add tests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed 'defaultArgon2Treads' to 'defaultArgon2Threads' to correct a spelling error. Updated all instances to ensure consistency and prevent potential confusion in the codebase.
Introduce comprehensive tests for Argon2 configuration, encoding, and decoding. Includes validation of default and custom settings, error handling for invalid inputs, and key derivation correctness with expected outputs.
Improved error handling by returning detailed errors when failing to read encryption parameters. Replaced direct EOF comparison with errors.Is for better compatibility and clarity. This ensures more robust and descriptive error messages during the decryption process.
Added detailed comments to error variables to provide clearer context on their usage and potential causes. This improves code readability and aids future debugging efforts.
The `t.Log(err)` statement was unnecessary as the error is already checked and handled in the test. Removing it improves code clarity and avoids clutter in test outputs.
The test for encoding with an invalid memory setting was removed as it is no longer relevant or aligns with the current implementation. This simplifies the test suite by eliminating unnecessary or outdated cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.