Generare QR Codes as SVG #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves Issue #93 |
|
Additional changes:
|
…R Code generation methods;
… general (no longer needed);
…ions of rqrcode);
…rences to Sprockets and JavaScript (no longer needed);
…e additional containing element (no longer needed);
… QR Code; update README and test app for change;
strouptl
force-pushed
the
svg_qr_code
branch
from
68bbf8d to
0258c88
Compare
|
Rebased. |
|
Note that we would need to direct existing users in the Changelog to remove devise-otp.js from their JavaScript, and add devise-otp.css to their CSS; |
|
FYI, DHH has announced that no new Rails projects should be started with Sprockets. So, I think we are making this change just in time. |
|
It works well for me, thanks, and sorry about the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This Pull Request updates devise otp to generate QR Codes as SVGs via the rqrcode gem. This eliminates any JavaScript or Sprockets dependencies in preparation for importmaps (now the only option for new apps in Rails 8).
Changes: