Native Warden Authentication #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tications directly to OTP Credentials controller rather than logging in; delete Sessions hook with overwritten logout/login "create_session" method (no longer needed);
…move challenge, recovery, and resource variables to filters for easier reference; unnest "challenge" and "recovery" fields in form params for consistency between show and update actions;
… blank challenges (resolves "undefined method root_url" error);
…in_at when present; - Break apart needs_credential_refresh? method, and set return URL within otp_tokens controller for simplicity; - Remove 'refresh_otp_credentials_for(resource)' from create_otp_session method (no longer needed);
… for refreshing this on sign_in (similar to Trackable);
|
@strzibny, what would you think about adding a dedicated require_mandatory_otp! helper, similar to the "authenticate_{scope}!" helpers, for forcing redirection to the edit_otp_token path for mandatory otp? This approach would necessitate you adding that helper to your application controller (or whichever you use as the base for that portion of your app), alongside of authenticate_user! We would just need to note in the README that you need to add this to whatever scope you want to require mandatory_otp for. |
|
Closing PR. Will open a new PR with a simpler solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the "database_authenticatable" warden strategy to redirect to OTP challenge if OTP is enabled. Benefits include:
Outstanding issues: