Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop exec, pause, resume, and signal #3

Merged
merged 1 commit into from
Dec 8, 2015

Commits on Dec 8, 2015

  1. Drop exec, pause, resume, and signal

    All of these require state information to be shared between funC
    invocations (to map from a container ID to the
    cgroups/namespaces/etc.), and after today's meeting we may be backing
    away from that [1,2].  Even if we keep a requirement for sharing state
    between funC invocations, we don't want to specify these IPC-requiring
    commands until we have more clarity on that requirement in the spec.
    
    On systems like Solaris, the kernel maintains a registry of container
    IDs directly, so they don't need an external registry [3].  But
    without a consensus around the minimal amount of inter-process state
    sharing, we don't want to require container ID → state lookups in the
    command-line spec.  Once we have more clarity on a minimal required
    mechanism (e.g. Julz's --state-file [4,5,6]), we can add them back in
    with an API that all runtimes can easily support (although runtimes
    are of course free to provide more convenient APIs as additional
    extensions).
    
    Pause, resume, and signal are still in the current lifecycle pull
    request [7], but I've requested they be removed until we have more
    clarity around the basic lifecycle [8].
    
    [1]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2015/opencontainers.2015-12-02-18.01.html
    [2]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2015/opencontainers.2015-12-02-18.01.log.html#l-79
    [3]: #3 (comment)
    [4]: #3 (comment)
    [5]: #3 (comment)
    [6]: #3 (comment)
    [7]: mrunalp/specs@bd549a2#diff-b84a8d65d8ed53f4794cd2db7e8ea731R48
    [8]: https://github.com/opencontainers/specs/pull/231/files#r45532412
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    Reviewed-by: Mike Brown <brownwm@us.ibm.com>
    Reviewed-by: Jesse Butler <jeeves.butler@gmail.com>
    Reviewed-by: Julian Friedman <julz.friedman@uk.ibm.com>
    wking committed Dec 8, 2015
    Configuration menu
    Copy the full SHA
    b922732 View commit details
    Browse the repository at this point in the history