Have type_caster for Eigen::Map create its own temp array #691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
type_caster<Eigen::Map<...>>
create its own copy of the inputNDArray
cleanup_list *cleanup
arg infrom_python
).Eigen::Ref
will then dispatch to theMap
type caster with dynamic strides and rely on its constructor creating an internal copyRef::m_object
, which was the previous behaviour)test_eigen.cpp|test_eigen.py
which tests a function with argumentstd::vector<Eigen::Ref<const VectorXd>>
, which creates a temp copy when an array with the wrong order is given.Fixes #682