Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bytearray wrapper type #654

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Add bytearray wrapper type #654

merged 4 commits into from
Aug 13, 2024

Conversation

noahbkim
Copy link
Contributor

I tried to follow the precedent of nanobind::bytes as closely as seemed reasonable. RFC on the documentation and signature of resize. Thanks @oremanj for feedback on the first iteration.

oremanj
oremanj reviewed Jul 26, 2024
View reviewed changes
include/nanobind/nb_types.h Outdated Show resolved Hide resolved
docs/api_core.rst Outdated Show resolved Hide resolved
include/nanobind/nb_types.h Outdated Show resolved Hide resolved
include/nanobind/nb_types.h Show resolved Hide resolved
oremanj
oremanj approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@oremanj oremanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for first pass, over to @wjakob.

wjakob
wjakob reviewed Aug 5, 2024
View reviewed changes
Copy link
Owner

@wjakob wjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just 2 small comments..

docs/api_core.rst Outdated Show resolved Hide resolved
include/nanobind/nb_types.h Outdated Show resolved Hide resolved
@wjakob
Copy link
Owner

wjakob commented Aug 11, 2024

(Seems that there is a merge conflict.)

@noahbkim
Copy link
Contributor Author

I think I fixed it!

@wjakob wjakob merged commit 865e638 into wjakob:master Aug 13, 2024
24 checks passed
wjakob pushed a commit that referenced this pull request Aug 13, 2024
@noahbkim @wjakob
Add bytearray wrapper type (#654)
8e5fd14 
* Add bytearray wrapper type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjakob wjakob wjakob left review comments

@oremanj oremanj oremanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahbkim @wjakob @oremanj