Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nb_list.h to allow for std::vector<bool>, see #255 #256

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Update nb_list.h to allow for std::vector<bool>, see #255 #256

merged 3 commits into from
Aug 10, 2023

Conversation

maximiliank
Copy link
Contributor

@wjakob
Copy link
Owner

wjakob commented Aug 9, 2023

Looks great! Could you add a test as well (which would not compile without the change).

@wjakob wjakob merged commit a0d26d2 into wjakob:master Aug 10, 2023
16 checks passed
@wjakob wjakob mentioned this pull request Aug 10, 2023
Closed
@maximiliank maximiliank deleted the maximiliank-patch-1 branch August 10, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximiliank @wjakob