Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ButtonProps to use IconProps for iconProps type #3483

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Update ButtonProps to use IconProps for iconProps type #3483

merged 1 commit into from
Jan 22, 2025

Conversation

nitzanyiz
Copy link
Collaborator

Description

Changed ButtonProps.iconProps to use IconProps instead of ImageProps.

Changelog

Button - Fixed iconProps to use IconProps;

Additional info

MADS-4593

@nitzanyiz nitzanyiz requested a review from adids1221 January 14, 2025 10:07
@nitzanyiz nitzanyiz marked this pull request as ready for review January 14, 2025 10:08
adids1221
adids1221 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@adids1221 adids1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nitzanyiz nitzanyiz merged commit cb907f9 into master Jan 22, 2025
1 check passed
@nitzanyiz nitzanyiz deleted the fix/Button/fixIconPropsTypings branch January 22, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adids1221 adids1221 adids1221 approved these changes

@shaizdragon87 shaizdragon87 shaizdragon87 approved these changes

Assignees

@adids1221 adids1221

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitzanyiz @adids1221 @shaizdragon87