Fix boolean type when converting to js #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In iOS, `@(YES)` is converted as `[NSNumber numberWithBool:]`, generating a `__NSCFBoolean` instance. While `@(1 == 1)` is converted as `[NSNumber numberWithInt:]`, generating a `__NSCFNumber` instance. And RN converter treat this differently. The first one becomes bool value, and the second one becomes numberic value.
xilin
changed the title
yogevbd
approved these changes
Nov 23, 2020
yogevbd
added
iOS
type: accepted/enhancement
type: accepted/bug
and removed
type: accepted/enhancement
labels
mburmistrov
pushed a commit
to mburmistrov/react-native-notifications
that referenced
this pull request
Jan 10, 2021
In iOS, `@(YES)` is converted as `[NSNumber numberWithBool:]`, generating a `__NSCFBoolean` instance.
While `@(1 == 1)` is converted as `[NSNumber numberWithInt:]`, generating a `__NSCFNumber` instance.
And RN converter treat this differently. The first one becomes bool value, and the second one becomes numberic value.
This PR makes sure the return value from native side will match type declaration in ts file `lib/src/interfaces/NotificationPermissions.ts`:
```
export interface NotificationPermissions {
badge: boolean;
alert: boolean;
sound: boolean;
}
```
Co-authored-by: Xi Lin <lxi@tesla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iOS,
@(YES)is converted as[NSNumber numberWithBool:], generating a__NSCFBooleaninstance.While
@(1 == 1)is converted as[NSNumber numberWithInt:], generating a__NSCFNumberinstance.And RN converter treat this differently. The first one becomes bool value, and the second one becomes numberic value.
This PR makes sure the return value from native side will match type declaration in ts file
lib/src/interfaces/NotificationPermissions.ts: