feat(infiniteAgendaList): support passing scrollViewProps #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Jul 11, 2024
| @@ -244,7 +243,7 @@ const InfiniteAgendaList = (props: AgendaListProps) => { | |||
| layoutProvider={layoutProvider} | |||
| onScroll={_onScroll} | |||
| onVisibleIndicesChanged={_onVisibleIndicesChanged} | |||
| scrollViewProps={{onMomentumScrollEnd: _onMomentumScrollEnd, nestedScrollEnabled: true, refreshControl}} | |||
| scrollViewProps={{nestedScrollEnabled: true, ...props, onMomentumScrollEnd: _onMomentumScrollEnd}} | |||
There was a problem hiding this comment.
You're passing all the props... this can cause a problem for example to the onScroll we pass the _onScroll and now scrollViewProps gets the props.onScroll. I don't like it. IMO is is better to create a proper const _scrollViewProps that passes only the relevant props with regard to what we want the user to override and what not
Inbal-Tish
reviewed
Jul 11, 2024
Inbal-Tish
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
AgendaListPropsextendsSectionListPropswe can receive any section list props.This PR just moves them to the right place inside
InfiniteAgendaList