fix: Lodash security vulnerability #208
Merged
+2,808
−2,697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange that the testing fails on node 6 |
|
do you need all the noise about babel changes in your PR, just to bump the lodash dependency? |
|
Then it fails the test, hence the "noise". That's why the bump first, then fail, then fix babel "noise" and pass, as per the history of the PR. |
kevinzang
pushed a commit
to udemy-archive/js-tooling
that referenced
this pull request
Aug 12, 2019
1) we’re using lodash, not underscore, in website-django 2) the lodash plugin has fixed lodash security issue: wix-incubator/eslint-plugin-lodash#208
kevinzang
pushed a commit
to udemy-archive/js-tooling
that referenced
this pull request
Aug 13, 2019
* Upgrade lerna to resolve security issues WS-2018-0236: Upgrade mem to version 4.0.0 or later. CVE-2019-10744: Upgrade lodash.template to version 4.5.0 or later. WS-2019-0064: Upgrade handlebars to version 4.0.14 or later. * Dedup lodash,js-yaml to resolve security issues CVE-2019-10744: Upgrade lodash to version 4.17.13 or later. WS-2019-0032, WS-2019-0063: Upgrade js-yaml to version 3.13.1 or later. * Ignore .DS_Store files * Replace underscore plugin with lodash plugin 1) we’re using lodash, not underscore, in website-django 2) the lodash plugin has fixed lodash security issue: wix-incubator/eslint-plugin-lodash#208 * lerna v3 doesn’t need “lerna” key in lerna.json * Publish - babel-polyfill-udemy-website@9.0.11 - babel-preset-udemy-website@11.0.8 - eslint-config-tester@3.0.1 - eslint-config-udemy-babel-addons@6.0.1 - eslint-config-udemy-basics@8.0.5 - eslint-config-udemy-jasmine-addons@8.0.2 - eslint-config-udemy-react-addons@10.0.3 - eslint-config-udemy-website@12.0.10 - eslint-plugin-udemy@9.0.3 - prettier-config-udemy@1.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#207