-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add [history] spec #2040
base: master
Are you sure you want to change the base?
add [history] spec #2040
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA GGONZALEZ180 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Overviewsrc/history.ts:Info: |
Hello @programmer4229,
Please add a 👍 as a reaction to this comment to show that you read this. |
Hey @programmer4229 can you sign the CLA? |
subcommands: [ | ||
{ | ||
name: "0", | ||
description: "Shows full command history", | ||
}, | ||
{ | ||
name: "|", | ||
description: "Divider to run other commands on history", | ||
subcommands: [ | ||
{ | ||
name: "grep", | ||
description: "Search history", | ||
}, | ||
], | ||
}, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should not be subcommands. 0
is an argument. (You can pass a number of history items you wish to show.)
The pipe and "grep" should be removed entirely since these are not syntax of the history command, but other shell constructs and commands.
fixes issue #2039