Support Go to Definition requests for source file labels in string literals

[withered-magic]

Adds the equivalent of the functionality described in bazel-contrib/vscode-bazel#380

[sluongng]

hmm does this work?

I tested it with BuildBuddy.git and Bazel.git, both cannot do Go to Def for most target labels. For example:

gazelle_binary(
    name = "bb_gazelle_binary",
    languages = DEFAULT_LANGUAGES + ["@bazel_gazelle//language/bazel/visibility:go_default_library"],
)

trying to "go to def" on "@bazel_gazelle//language/bazel/visibility:go_default_library" would fail.

[withered-magic]

Ah sorry, didn't clarify in the PR that this is specifically for source files, e.g. //path/to/source.cc - I'm planning on following up with goto def for normal labels

[withered-magic]

Just updated this PR description to indicate this, and opened #203 to track the remaining functionality!

[sluongng]

I don't think it works. For example, I tried it on this line https://github.com/buildbuddy-io/buildbuddy/blob/bb4c9d9ff75ace7c549819e40cac080414a6a226/server/buildbuddy_server/BUILD#L71 and it did not open the Go file.

Also I think it's typical to have source syntax in the form of //some/package:local/package/path.ext and/or local/package/path.ext for short.

[withered-magic]

Hmm, for my setup it's working from that file for all the various forms of source syntax that you mentioned:

Screen.Recording.2024-04-16.at.10.44.56.AM.mov

This functionality isn't actually on the latest release yet, are you using a custom build from latest main? The version in the Bazel LSP Client logs should be (the unreleased) v0.1.12:

server: starpls, v0.1.12
server: initializing state and starting event loop

[sluongng]

ah I built from the latest from main, but I copied the old binary from editors/code/bin/starpls instead of directly from my bazel-out. 😮‍💨

sorry for the noise

[withered-magic]

no worries! i'll follow up on the non-source labels soon

[withered-magic]

Goto def for non-source file labels has been added in #205!

[sluongng]

Amazing! I love starpls already!