Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for some llama.cpp params on LlamaModel #5

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Aug 16, 2023

Description of change

Added support for some llama.cpp params on LlamaModel

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@giladgd giladgd requested a review from ido-pluto August 16, 2023 21:56
@giladgd giladgd self-assigned this Aug 16, 2023
private readonly _model: LLAMAModel;
private readonly _prependBos: boolean;
/** @internal */
public readonly _model: LLAMAModel;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very cool feature you using!

@giladgd giladgd merged commit c76ec48 into master Aug 17, 2023
6 checks passed
@giladgd giladgd deleted the supportParams branch August 17, 2023 16:22
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants