Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add social icons to mobile menu footer #988

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Add social icons to mobile menu footer #988

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff71465
Add social icons to MobileMenuFooter.astro
magicDGS Oct 25, 2023
902d552
Add changeset
magicDGS Oct 25, 2023
28954a0
Apply suggestions from code review
magicDGS Oct 27, 2023
c4e912b
Add vertical padding to social icons
delucis Nov 1, 2023
42aa535
Update changeset
delucis Nov 1, 2023
b7bb16b
Merge branch 'main' into magicDGS/#978
delucis Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-geckos-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/starlight': patch
---

Add social icons to MobileMenuFooter
9 changes: 8 additions & 1 deletion packages/starlight/components/MobileMenuFooter.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
---
import { LanguageSelect, ThemeSelect } from 'virtual:starlight/components';
import { LanguageSelect, ThemeSelect, SocialIcons } from 'virtual:starlight/components';
import type { Props } from '../props';
---

<div class="mobile-preferences sl-flex">
<div class="sl-flex social-icons">
<SocialIcons {...Astro.props} />
</div>
<ThemeSelect {...Astro.props} />
<LanguageSelect {...Astro.props} />
</div>

<style>
.social-icons {
gap: 1rem;
magicDGS marked this conversation as resolved.
Show resolved Hide resolved
align-items: center;
delucis marked this conversation as resolved.
Show resolved Hide resolved
}
magicDGS marked this conversation as resolved.
Show resolved Hide resolved
.mobile-preferences {
justify-content: space-between;
border-top: 1px solid var(--sl-color-gray-6);
magicDGS marked this conversation as resolved.
Show resolved Hide resolved
Expand Down