Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ru): added translations for i18n, overriding-components, sidebar #919

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

Lootjs
Copy link
Contributor

@Lootjs Lootjs commented Oct 16, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

Pages that were translated: i18n, overriding-components, sidebar


Could someone add the hacktoberfest-accepted label? 👀

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: b269c59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit b269c59
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6537e7458a6a01000858612c
😎 Deploy Preview https://deploy-preview-919--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Oct 16, 2023
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

I left some questions/comments mostly about a few missing changes that I may have spotted.

docs/src/content/docs/ru/guides/customization.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ru/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ru/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ru/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ru/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ru/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ru/guides/overriding-components.md Outdated Show resolved Hide resolved
@Lootjs
Copy link
Contributor Author

Lootjs commented Oct 17, 2023

hmm, my translations were outdated :(

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, really appreciated.

docs/src/content/docs/guides/sidebar.mdx Outdated Show resolved Hide resolved
@Lootjs
Copy link
Contributor Author

Lootjs commented Oct 19, 2023

Is there anything else that I need to fix? 🤔

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good @Lootjs — thank you!

Just spotted one link that needs updating.

docs/src/content/docs/ru/guides/overriding-components.md Outdated Show resolved Hide resolved
@delucis delucis added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 24, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! 🙌

@delucis delucis merged commit 5bb1733 into withastro:main Oct 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants