Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr): add guides/overriding-components.md & reference/overrides.md #834

Merged
merged 5 commits into from
Oct 11, 2023
Merged

i18n(fr): add guides/overriding-components.md & reference/overrides.md #834

merged 5 commits into from
Oct 11, 2023

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Oct 7, 2023 •
edited
Loading

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

This pull request adds the french translation of the guides/overriding-components.md and reference/overrides.md pages (including the fix from #833).

Regarding the translation of override in french, there are multiple possibilities:

  • remplacer which would be the most accurate translation for the common replace verb.
  • surcharger which would be the most accurate translation for overload in the context of programming, e.g. Java method overloading.
  • redéfinir which would be the most accurate translation for override in the context of programming, e.g. Java method overriding.

Considering the definitions of overloading and overriding in the context of programming, I went with redéfinir (verb) and redéfinition (noun) for the translation of override in the context of Starlight components.

A small note about render too which is used a lot in these pages, as far as I know, we do not really use the translation of the verb render in french in this context. This is also visible in the french React docs where rendre is never used compared to the english version. We have the word rendu that can be used but it is a noun, so in this translation, when a verb is needed I often fallback to utilisé (used) or affiché (displayed).

I am also taking part in Hacktoberfest.

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 673b92f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 7, 2023 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 673b92f
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/652652c957f5ab0007ee81bb
😎 Deploy Preview https://deploy-preview-834--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Oct 7, 2023
HiDeoo
HiDeoo commented Oct 7, 2023
View reviewed changes
docs/src/content/docs/fr/reference/overrides.md

Pour en savoir plus, consultez le [guide des redéfinitions de composants](/fr/guides/overriding-components/).

## Props des composants
Copy link
Member Author

@HiDeoo HiDeoo Oct 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "props" like the Astro docs and the french React docs.

docs/src/content/docs/fr/reference/overrides.md

**Type:** `string | undefined`

Le chemin de base utilisé pour servir une langue. `undefined` pour les slugs de la locale racine.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, there is no french word for "slug" in this context. Also not translated in the french version of MDN.

docs/src/content/docs/fr/reference/overrides.md

## Composants

### Métadonnées
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"head" and "header" are usually translated both using "en-tête" which would be annoying in this page to use the same word so I used "Métadonnées" like on MDN.

docs/src/content/docs/fr/reference/overrides.md
**Composant par défaut:** [`PageFrame.astro`](https://github.com/withastro/starlight/blob/main/packages/starlight/components/PageFrame.astro)

Composant de mise en page contenant la plupart du contenu de la page.
L'implémentation par défaut configure la mise en page de l'en-tête, de la barre latérale et du contenu principal et inclut des emplacements (slots) nommés `header` et `sidebar` en plus de l'emplacement par défaut pour le contenu principal.
Copy link
Member Author

@HiDeoo HiDeoo Oct 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same syntax for slots as the Astro Docs.

delucis
delucis approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great — thanks @HiDeoo! Just noticed one link issue that also came up in another translation PR.

docs/src/content/docs/fr/guides/overriding-components.md Outdated Show resolved Hide resolved
@HiDeoo
Copy link
Member Author

HiDeoo commented Oct 11, 2023 •
edited
Loading

Adding myself the hacktoberfest-accepted tag before merging, hope that is ok.

@HiDeoo HiDeoo added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 11, 2023
@HiDeoo HiDeoo merged commit 3a62bb8 into withastro:main Oct 11, 2023
9 checks passed
@HiDeoo HiDeoo deleted the hd-i18n-fr-0-11-0-overriding-components branch October 11, 2023 08:02
liruifengv pushed a commit to liruifengv/starlight that referenced this pull request Oct 11, 2023
@HiDeoo @delucis @liruifengv
i18n(fr): add guides/overriding-components.md & `reference/override…
3d395e2 
…s.md` (withastro#834)

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiDeoo @delucis