-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(hi): add components.mdx
#1371
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the translation @at-the-vr! Left a few notes.
|
||
<Icon name="star" color="goldenrod" size="2rem" /> | ||
|
||
#### All icons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here this should be translated (and any #all-icons
links updated to match).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, all of them were useful (especially the headings one) 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation 🙌 I also left a few small comments (I don't think they're duplicate with the ones from Chris).
Just a small note as I may not have been clear with the comment regarding |
I am laughing and contemplating about what just happened, I am not using TODO terminologies for pending translation again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @at-the-vr — and he detailed review @HiDeoo, I totally missed those!
Just spotted one last thing but otherwise LGTM 🚀
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @at-the-vr — LGTM! 🚀
Description