Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(hi): add components.mdx #1371

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

at-the-vr
Copy link
Member

@at-the-vr at-the-vr commented Jan 14, 2024

Description

  • add translation for Components in hindi language

Copy link

changeset-bot bot commented Jan 14, 2024

⚠️ No Changeset found

Latest commit: 4f1739f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jan 16, 2024 10:36am
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 10:36am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Jan 14, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the translation @at-the-vr! Left a few notes.

docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved

<Icon name="star" color="goldenrod" size="2rem" />

#### All icons
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here this should be translated (and any #all-icons links updated to match).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, all of them were useful (especially the headings one) 😄

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌 I also left a few small comments (I don't think they're duplicate with the ones from Chris).

docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved
@HiDeoo
Copy link
Member

HiDeoo commented Jan 15, 2024

Just a small note as I may not have been clear with the comment regarding //TODO and I see that you just translated it. I think this is something you added and forgot to remove as this is not present in the original content.

@at-the-vr
Copy link
Member Author

Just a small note as I may not have been clear with the comment regarding //TODO and I see that you just translated it. I think this is something you added and forgot to remove as this is not present in the original content.

I am laughing and contemplating about what just happened, I am not using TODO terminologies for pending translation again

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @at-the-vr — and he detailed review @HiDeoo, I totally missed those!

Just spotted one last thing but otherwise LGTM 🚀

docs/src/content/docs/hi/guides/components.mdx Outdated Show resolved Hide resolved
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @at-the-vr — LGTM! 🚀

@delucis delucis merged commit 4ba5389 into withastro:main Jan 16, 2024
9 checks passed
@at-the-vr at-the-vr deleted the atv/i18n/hi/components branch May 22, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants