Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify Adapter: Add callout on 404 behaviour #6546

Closed
wants to merge 1 commit into from

Conversation

Skn0tt
Copy link

@Skn0tt Skn0tt commented Jan 23, 2024

Description (required)

As discussed in withastro/adapters#133.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 23, 2024 3:24pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918
Copy link
Member

Hi @Skn0tt ! I chatted with the team further about this, and we don't think anything added to docs here is needed at this time! We appreciate you adding this to cover the bases, but let's wait until there's evidence that this is causing a widespread problem with a substantial number of users before calling attention to it, especially since there's active feature development being done around 404 pages.

So, you're off the hook here! 🙌

@sarah11918 sarah11918 closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants