Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-cn): Update environment-variables.mdx & configuring-astro.mdx #5256

Merged
merged 4 commits into from
Nov 2, 2023
Merged

i18n(zh-cn): Update environment-variables.mdx & configuring-astro.mdx #5256

merged 4 commits into from
Nov 2, 2023

Conversation

liruifengv
Copy link
Member

@liruifengv liruifengv commented Nov 2, 2023 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented Nov 2, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d7c7c1e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/654395b40e75fd00081f2368
😎 Deploy Preview https://deploy-preview-5256--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liruifengv liruifengv marked this pull request as ready for review November 2, 2023 01:15
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 2, 2023
@liruifengv liruifengv changed the title i18n(zh-cn): Update environment-variables.mdx i18n(zh-cn): Update environment-variables.mdx & configuring-astro.mdx Nov 2, 2023
@liruifengv
Copy link
Member Author

Merge after #5258

100gle
100gle approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@100gle 100gle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanthomasdev
yanthomasdev approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work 👏

@yanthomasdev yanthomasdev merged commit e2bfb49 into withastro:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100gle 100gle 100gle approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import.meta.env incorrectly rendered in Asides
3 participants
@liruifengv @100gle @yanthomasdev