Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: New RSS package! #430

Merged
merged 26 commits into from
May 4, 2022
Merged

Feat: New RSS package! #430

merged 26 commits into from
May 4, 2022

Conversation

bholmesdev
Copy link
Contributor

This documents our shiny new @astrojs/rss package (coming soon to an npm near you 👀 ). Some notable additions:

  • New "Using @astrojs/rss" on our RSS guide
  • Revisions to the old getStaticPaths docs. This will not be removed for Astro 1.0, so we'll maintain this documentation for legacy purposes.
  • A new "default environment variables" section on our env variable docs. We introduced a new import.meta.env.SITE variable to pull off RSS, so I felt this deserved some documentation.

@netlify
Copy link

netlify bot commented May 3, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit f5eab9f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6271a52cf3afd30009432085
😎 Deploy Preview https://deploy-preview-430--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bholmesdev and others added 10 commits May 3, 2022 15:15
@sarah11918
Copy link
Member

(A propos of nothing .... does it make you feel any better that I now wish I had just edited the whole file and changed all the import.metas at once?)

bholmesdev and others added 4 commits May 3, 2022 16:50
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@bholmesdev
Copy link
Contributor Author

@sarah11918 I mean, that's how I would've done it 😉 Had fun with the commit messages anyways.

This should be all the edits btw. Lmk if it's good to go!

@sarah11918
Copy link
Member

sarah11918 commented May 3, 2022

LGTM! @bholmesdev

Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 final comments. Would love to chat through in person if you're not on board with either of them!

src/pages/en/guides/rss.md Outdated Show resolved Hide resolved
src/pages/en/guides/rss.md Show resolved Hide resolved
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bholmesdev bholmesdev merged commit 826d0c0 into main May 4, 2022
@bholmesdev bholmesdev deleted the feat/new-rss-package branch May 4, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants