feat(image_services): Add mention of new validateOptions hook #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Princesseuh
added
the
merge-on-release
|
Could we add |
There was a problem hiding this comment.
LGTM! But I do agree with @Jutanium here, might be helpful to have an example.
|
Core PR has been merged, will merge this when it's released |
|
Merging-on-release, but we have an example ready to add in a separate PR. |
sarah11918
added
the
minor-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
withastro/astro#6555 adds a new hook to the Image Service API that can be used to validate and augment the passed options. The built-in services uses this hook to set the default format as
webpif the user hasn't passed a format, for example.It takes the same
optionsas the other hooks, so anImageTransformand it returns an ImageTransform as well. Returning anImageTransformis mandatory, so the implementation should probably always end withreturn options;This PR additionally contain some misc fix to the rest of the file