Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rehype heading IDs plugin #2216

Merged
merged 9 commits into from
Dec 28, 2022
Merged

Document rehype heading IDs plugin #2216

merged 9 commits into from
Dec 28, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Dec 20, 2022

What kind of changes does this PR include?

  • New or updated content

Description

@delucis delucis added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Dec 20, 2022
@delucis delucis self-assigned this Dec 20, 2022
@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 10a2727
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63ac5d572fd06b0009963a93
😎 Deploy Preview https://deploy-preview-2216--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @delucis! This is so helpful and looks great! I made a few tiny tweaks to see what you think, and left a question I was still left with after reading the text, so maybe others would have it, too!

delucis and others added 2 commits December 21, 2022 16:07
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
- We already have a “Heading IDs” subheader further up the page so this clarifies the plugins combo for search results
- Since is confusing here because it only really refers to the `rehypeHeadingIds` plugin.
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@delucis delucis merged commit 171ea37 into main Dec 28, 2022
@delucis delucis deleted the chris/heading-ids branch December 28, 2022 15:34
kyosuke added a commit to kyosuke/docs.astro.build that referenced this pull request Mar 25, 2023
yanthomasdev added a commit that referenced this pull request Mar 27, 2023
* Translate 'front-matter' to 'フロントマター' in markdown-content.mdx based on the provided vocabulary list for translation

* Document rehype heading IDs plugin (#2216)

171ea37

* [i18nIgnore] Fix broken syntax highlight in code block (#2716)

e177bd4

* docs: markdown content: Add section about how to customize the plugins ( #2632)

895c4b9

* Update Markdown content docs for config rework (#2280)

c065903

* Update markdown-content.mdx

* Update markdown-content.mdx

* Add translations for new sentences in the update

* Update markdown-content.mdx

* Update src/content/docs/ja/guides/markdown-content.mdx

Co-authored-by: jigsaw <jigsaw@live.jp>

* Update troubleshooting.mdx

---------

Co-authored-by: jigsaw <jigsaw@live.jp>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants