-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generics handling that occurs before Props
#702
Conversation
🦋 Changeset detectedLatest commit: 2c26adb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great to me! fixes the extant bug
I guess this PR won't be needed anymore? |
Hmm I'm not sure! The original should work once this change makes its way into VS Code, but that might take a while Edit: added a fixture for the image props, so it looks like those will be handled properly! Will leave it to @Princesseuh to decide on the original PR. |
Changes
Props
yetTesting
All existing tests pass, one test added for edge case
Docs
Bug fix only