-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug that Japanese files were not displayed correctly. #9866
Conversation
🦋 Changeset detectedLatest commit: 3292857 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix seems sound to me
Can you add a new test case, please? You want to add a new asset here: https://github.com/withastro/astro/tree/main/packages/astro/test/fixtures/astro-assets-prefix/ and update the Add a new test assertion in this file:
|
@ematipico and now Add test case. Is this test case clear? |
That's very clear, thank you! |
fix #9842
Changes
Decode
node.properties.src
and to be the same asfile.data.imagePaths
value.Testing
I ran
pnpm --filter @example/blog run dev
and tested that the files were displayed correctly.Docs
I don't think an update is necessary.