Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that Japanese files were not displayed correctly. #9866

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

ktym4a
Copy link
Contributor

@ktym4a ktym4a commented Jan 29, 2024

fix #9842

Changes

Decode node.properties.src and to be the same as file.data.imagePaths value.

Testing

I ran pnpm --filter @example/blog run dev and tested that the files were displayed correctly.

Docs

I don't think an update is necessary.

Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: 3292857

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Jan 29, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix seems sound to me

@ematipico
Copy link
Member

ematipico commented Jan 29, 2024

Can you add a new test case, please?

You want to add a new asset here: https://github.com/withastro/astro/tree/main/packages/astro/test/fixtures/astro-assets-prefix/ and update the markdown.md page.

Add a new test assertion in this file:

import { loadFixture } from './test-utils.js';

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 29, 2024
@ktym4a
Copy link
Contributor Author

ktym4a commented Jan 29, 2024

@ematipico
Thanks! I wanted to add a test case but didn't know where to put it.

and now Add test case.
I have also checked that the test fail before fix.

Is this test case clear?

@ematipico
Copy link
Member

@ematipico Thanks! I wanted to add a test case but didn't know where to put it.

and now Add test case. I have also checked that the test fail before fix.

Is this test case clear?

That's very clear, thank you!

@ematipico ematipico merged commit 44c957f into withastro:main Jan 29, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astro build can't handle images with Chinese paths
2 participants