fix(i18n): use define to deliver config to virtual module

[lilnasy]

Changes

• Switches the approach used to deliver i18n config to the astro:i18n module.
• The virtual module approach broke in mysterious ways.

Testing

Existing tests should pass.

Docs

Does not affect usage.

[changeset-bot]

🦋 Changeset detected

Latest commit: 288128f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[natemoo-re]

Not my favorite solution, but if it works, it works!

[ematipico]

Can we add a test? As far as I understood, there was a way to reproduce it

[lilnasy]

The error happens on dev startup, during some work being performed by a plugin called vite:dep-scan. It would be simpler if it happened on request. I'm not confident a test can catch but I'll take a look.

[lilnasy]

No luck.

The fact that a fetch request itself will succeed with expected html aside, the bug won't even happen in our monorepo. It seems to be one of these cases where vite is sensitive to whether astro is linked or copied to node_modules.

[ematipico]

Thank you for taking the time to explain and double check.

[bluwy]

Can you explain how this fixes the issue? Using import.meta.env this way may bloat the size if the user references import.meta.env itself in runtime.

EDIT: I missed your message that it happen in vite:dep-scan. I'm not sure how it hit that issue in the first place, but if we do want to use this trick, I think we should define something like __ASTRO_INTERNAL_I18n_CONFIG__ instead, so it's not prefixed with import.meta.env.*

[lilnasy]

AFAIK, it will not appear on import.meta.env. define only does a string replace, doesn't it?

[lilnasy]

I'm guessing astro-env-inject picks it up.

[bluwy]

AFAIK, it will not appear on import.meta.env. define only does a string replace, doesn't it?

Vite would use import.meta.env.* in define: https://github.com/vitejs/vite/blob/f9c33add88e8edcd54316629724730d8049447f1/packages/vite/src/node/plugins/define.ts#L50-L53. The entire object may get inlined for import.meta.env as it represents an object of all the keys and values.

[lilnasy]

I didn't know that, thanks!