Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent dev toolbar tooltip from overflowing #9512

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Prevent dev toolbar tooltip from overflowing #9512

merged 3 commits into from
Dec 26, 2023

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Dec 24, 2023 •
edited
Loading

Changes

Demonstration

Before After
before after

Testing

  • pnpm run test:e2e:match "dev-overlay"
  • A test case is added to ensure that tooltips near the corners do not overflow

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: f110d28

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 24, 2023
bluwy
bluwy approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works great! Nice tests too.

@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Dec 26, 2023
@Princesseuh Princesseuh merged commit 1469e0e into withastro:main Dec 26, 2023
13 of 14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 26, 2023
Merged
@mingjunlu mingjunlu deleted the fix/overflowing-dev-toolbar-tooltip branch December 26, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Astro Dev Toolbar doesn't show full audit
3 participants
@mingjunlu @bluwy @Princesseuh