Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): helpful message for DuplicateContentEntry #9492

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Dec 20, 2023

Changes

Testing

Does not affect behavior, existing tests should pass.

Docs

Does not affect usage.

Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: b477034

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 20, 2023
@lilnasy
Copy link
Contributor Author

lilnasy commented Dec 20, 2023

!preview dupicate-content-entry-improved-message

Copy link
Contributor

Snapshots have been released for the following packages:

  • @astrojs/preact@experimental--dupicate-content-entry-improved-message
  • @astrojs/react@experimental--dupicate-content-entry-improved-message
  • @astrojs/solid-js@experimental--dupicate-content-entry-improved-message
  • astro@experimental--dupicate-content-entry-improved-message
Publish Log
🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--dupicate-content-entry-improved-message tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/lit
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/node
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vercel
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  info astro is being published because our local version (0.0.0-dupicate-content-entry-improved-message-20231220220040) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.0.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.1 is already published on npm
🦋  warn create-astro is not being published because version 4.6.0 is already published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.3.1 is already published on npm
🦋  warn @astrojs/lit is not being published because version 4.0.0 is already published on npm
🦋  warn @astrojs/markdoc is not being published because version 0.8.1 is already published on npm
🦋  warn @astrojs/mdx is not being published because version 2.0.2 is already published on npm
🦋  warn @astrojs/node is not being published because version 7.0.2 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.0.2 is already published on npm
🦋  info @astrojs/preact is being published because our local version (0.0.0-dupicate-content-entry-improved-message-20231220220040) has not been published on npm
🦋  info @astrojs/react is being published because our local version (0.0.0-dupicate-content-entry-improved-message-20231220220040) has not been published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.0.3 is already published on npm
🦋  info @astrojs/solid-js is being published because our local version (0.0.0-dupicate-content-entry-improved-message-20231220220040) has not been published on npm
🦋  warn @astrojs/svelte is not being published because version 5.0.2 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.0.4 is already published on npm
🦋  warn @astrojs/vercel is not being published because version 6.1.0 is already published on npm
🦋  warn @astrojs/vue is not being published because version 4.0.5 is already published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.2.1 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.0.4 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.3.3 is already published on npm
🦋  warn @astrojs/upgrade is not being published because version 0.2.1 is already published on npm
🦋  info Publishing "astro" at "0.0.0-dupicate-content-entry-improved-message-20231220220040"
🦋  info Publishing "@astrojs/preact" at "0.0.0-dupicate-content-entry-improved-message-20231220220040"
🦋  info Publishing "@astrojs/react" at "0.0.0-dupicate-content-entry-improved-message-20231220220040"
🦋  info Publishing "@astrojs/solid-js" at "0.0.0-dupicate-content-entry-improved-message-20231220220040"
🦋  success packages published successfully:
🦋  astro@0.0.0-dupicate-content-entry-improved-message-20231220220040
🦋  @astrojs/preact@0.0.0-dupicate-content-entry-improved-message-20231220220040
🦋  @astrojs/react@0.0.0-dupicate-content-entry-improved-message-20231220220040
🦋  @astrojs/solid-js@0.0.0-dupicate-content-entry-improved-message-20231220220040
🦋  Creating git tags...
🦋  New tag:  astro@0.0.0-dupicate-content-entry-improved-message-20231220220040
🦋  New tag:  @astrojs/preact@0.0.0-dupicate-content-entry-improved-message-20231220220040
🦋  New tag:  @astrojs/react@0.0.0-dupicate-content-entry-improved-message-20231220220040
🦋  New tag:  @astrojs/solid-js@0.0.0-dupicate-content-entry-improved-message-20231220220040
Build Log

> root@0.0.0 build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro
• Running build in 26 packages
• Remote caching enabled
::group::create-astro:build
cache hit, suppressing logs 7058a3ca45129433
::endgroup::
::group::@astrojs/upgrade:build
cache hit, suppressing logs 179905e48019f429
::endgroup::
::group::@astrojs/prism:build
cache hit, suppressing logs 4c62f7ed62ed24e4
::endgroup::
::group::@astrojs/telemetry:build
cache hit, suppressing logs cc156f1cadee13c9
::endgroup::
::group::@astrojs/internal-helpers:build
cache hit, suppressing logs c9547c3dc40ded12
::endgroup::
::group::@astrojs/markdown-remark:build
cache hit, suppressing logs 4551e15d792fbc4e
::endgroup::
::group::astro:build
cache miss, executing e6257188d816f734

> astro@0.0.0-dupicate-content-entry-improved-message-20231220220040 build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild


> astro@0.0.0-dupicate-content-entry-improved-message-20231220220040 prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"


> astro@0.0.0-dupicate-content-entry-improved-message-20231220220040 postbuild /home/runner/work/astro/astro/packages/astro
> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm"

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing 27d57b2e1e7edfe5

> @astrojs/underscore-redirects@0.3.3 build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing 4b805777f4f9ab51

> @astrojs/partytown@2.0.2 build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/react:build
cache miss, executing 8561eca8ca60d283

> @astrojs/react@0.0.0-dupicate-content-entry-improved-message-20231220220040 build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/node:build
cache miss, executing e1b5912e57e11c5a

> @astrojs/node@7.0.2 build /home/runner/work/astro/astro/packages/integrations/node
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing abfaac1f5a19f416

> @astrojs/solid-js@0.0.0-dupicate-content-entry-improved-message-20231220220040 build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing 26da0a02e197d648

> @astrojs/preact@0.0.0-dupicate-content-entry-improved-message-20231220220040 build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing 5055e91d27647308

> @astrojs/markdoc@0.8.1 build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing cc5b7de2d0468602

> @astrojs/mdx@2.0.2 build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing 03ac8793e8230294

> @astrojs/vue@4.0.5 build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing 4512c511b499d0e4

> @astrojs/svelte@5.0.2 build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing e97f334ce4ed99f2

> @astrojs/alpinejs@0.3.1 build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/lit:build
cache miss, executing 3a828f9d4cc0b431

> @astrojs/lit@4.0.0 build /home/runner/work/astro/astro/packages/integrations/lit
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@benchmark/timer:build
cache miss, executing 1d2d882b40250713

> @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/rss:build
cache miss, executing 0cf981d7a37b23ff

> @astrojs/rss@4.0.1 build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing 5d2a868d06728006

> @astrojs/tailwind@5.0.4 build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vercel:build
cache miss, executing 8996360c333db813

> @astrojs/vercel@6.1.0 build /home/runner/work/astro/astro/packages/integrations/vercel
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing 4ca7a4829a4c979b

> @astrojs/sitemap@3.0.3 build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    24 successful, 24 total
Cached:    6 cached, 24 total
  Time:    38.864s 

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For easier review, here's the new message:
image

I think it's worth checking with the docs team as well if the message format is good.

@matthewp matthewp merged commit 89a2a07 into main Dec 27, 2023
13 checks passed
@matthewp matthewp deleted the helpful-error branch December 27, 2023 17:56
@astrobot-houston astrobot-houston mentioned this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants