Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing global attributes to JSX definition #9404

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

Princesseuh
Copy link
Member

Changes

Some newer attributes were missing from our definition, this fixes that.

Fix #9371

Testing

Tested manually!

Docs

N/A

Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: 638133e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 11, 2023
@Princesseuh Princesseuh changed the title Fix/missing global html attributes Add missing global attributes to JSX definition Dec 11, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One question on translate

@Princesseuh Princesseuh merged commit 8aa17a6 into main Dec 11, 2023
@Princesseuh Princesseuh deleted the fix/missing-global-html-attributes branch December 11, 2023 16:08
@astrobot-houston astrobot-houston mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"part" is missing from HTMLAttributes
3 participants