Fixes: Shiki syntax highlighting adds is:raw attribute to the HTML output #8715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c4016fa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
bluwy
approved these changes
Oct 4, 2023
Merged
martrapp
pushed a commit
that referenced
this pull request
Oct 4, 2023
…tput (#8715) Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran my page through the W3C validator and it showed me a bunch of errors and warnings about
is:rawbeing not allowed. Afaikis:rawis an Astro specific directive that should now appear on the static page output.The raw-attribute appears only in the Shiki highlighted syntax.
To reproduce it, you can use this template https://stackblitz.com/github/withastro/astro/tree/latest/examples/with-markdown-shiki
Changes
I removed the part of the
shikiplugin that adds theis:rawto thepre-tags. The fact thatis:rawis in the HTML output implies thatis:rawor a similar mechanic is already used higher up the chain.Testing
I added a Mocha test to verify the fix.
Docs
The attribute is hidden from the user and only visible when inspecting the page HTML. Browsers seem to ignore it and it only appeared as a "problem" when running a HTML validator on the page.