feat(assets): Add support for passing non-awaited imports to the Image component and getImage
#8066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e component and `getImage`
🦋 Changeset detectedLatest commit: 086c167 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Aug 14, 2023
natemoo-re
approved these changes
Aug 14, 2023
Merged
SudoCat
pushed a commit
to SudoCat/astro
that referenced
this pull request
Aug 14, 2023
…e component and `getImage` (withastro#8066) * feat(assets): Add support for passing non-awaited imports to the Image component and `getImage` * test: add test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What the title says. This is a pretty common request since when using inline imports, it's super annoying to have to await +
.defaultit, and especially when using components in MDX and stuff, you kinda want your code to be as neat as possible. Also, this worked in@astrojs/imageand people wanted it backTesting
Added a test
Docs
N/A, the proper path is already documented, this is something people might stumble upon