feat: remove automatic flattening of getStaticPaths result
#7845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60a73e3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Jul 27, 2023
ematipico
pushed a commit
that referenced
this pull request
Jul 31, 2023
* feat: remove automatic flattening of `getStaticPaths` result * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Aug 1, 2023
* feat: remove automatic flattening of `getStaticPaths` result * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Aug 1, 2023
* feat: remove automatic flattening of `getStaticPaths` result * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Aug 3, 2023
* feat: remove automatic flattening of `getStaticPaths` result * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Aug 8, 2023
* feat: remove automatic flattening of `getStaticPaths` result * chore: changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Early in Astro we tended to do some cute magic things for users, for convenience. And while it is nice in some cases, we shifted away from this and instead prefer that users be fully conscious of what they are doing.
This PR removes a
.flat()call we did ongetStaticPathsreturn value and adds an error if the user tries to return an unflattened arrayTesting
Updated tests!
Docs
Will be part of the 3.0 Migration Guide