Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix astro/app import #7821

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Fix astro/app import #7821

merged 5 commits into from
Aug 1, 2023

Conversation

ottomated
Copy link
Contributor

@ottomated ottomated commented Jul 26, 2023

Changes

  • Fixes a regression with importing 'astro/app'

Testing

  • Added a test that imports astro/app, confirmed that it fails in the case of missing a .js in the imports

Docs

N/A

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

🦋 Changeset detected

Latest commit: 584b7aa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's important! Thank you!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR!

@natemoo-re natemoo-re merged commit c00b6f0 into withastro:main Aug 1, 2023
@astrobot-houston astrobot-houston mentioned this pull request Aug 1, 2023
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants