Add caching for optimized images #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 07834bf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
|
This PR is blocked because it contains a |
matthewp
reviewed
May 4, 2023
matthewp
approved these changes
May 4, 2023
ematipico
reviewed
May 4, 2023
ematipico
approved these changes
May 4, 2023
matthewp
approved these changes
May 4, 2023
sarah11918
approved these changes
May 4, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new setting
cacheDir(default is./node_modules/.astro(same as@astrojs/image)) that is then used to cache optimized images in order to be able to reuse the build artifacts in subsequent builds.This should unblock larger website from using
astro:assets, as the previous implementation wasn't performant enoughTesting
Added tests
Docs
N/A