Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure multiple cookies set in dev result in multiple set-cookie headers #6973

Merged
merged 6 commits into from
May 3, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented May 2, 2023

Changes

Testing

  • Updated an existing test. Using raw sockets so that we can examine the raw response and see that there are 2 separate set-cookie headers. You can't examine this for sure using fetch because you can't see the raw response.

Docs

N/A bug fix

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: ea8facc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 2, 2023
@Princesseuh
Copy link
Member

The test that failed is related to the change here. Since all other pipelines passed, I'll just rerun it to see if it's flaky, but due to undici differences between versions I wouldn't necessarily be surprised if there's a real change

@matthewp matthewp merged commit 0883fd4 into main May 3, 2023
@matthewp matthewp deleted the multi-set-cookies-dev branch May 3, 2023 15:26
@astrobot-houston astrobot-houston mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set multiple cookies in response on v2
3 participants