Avoid removing leading slash for build.assetsPrefix
#6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35af017 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
May 2, 2023
|
Will wait for GitHub Actions to return to rerun the tests, to double-confirm that tests still pass before merging. |
matthewp
approved these changes
May 2, 2023
github-actions
bot
added
pkg: astro
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #6844
Update
joinPathsutility to not automatically strip the final path's leading and trailing slash. Surprisingly nothing breaks when I test it locally 😲This fixes
build.assetsPrefixjoining paths when the value is a root path like/prefix/with/me.Testing
Added a new test, also tested the local examples manually.
Docs
n/a. bug fix.