fix(node): Fix malformed URLs crashing the server in certain cases #6746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5b93104 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
github-actions
bot
added
the
pkg: astro
Princesseuh
commented
Apr 4, 2023
|
|
||
| for (const weirdUrl of weirdURLs) { | ||
| const fetchResult = await fixture.fetch(weirdUrl); | ||
| expect([400, 500]).to.include( |
There was a problem hiding this comment.
Certain URLs here return 500 instead of 400 because they pass the encodeUri, decodeUri, new URI stuff, but they fail later on in the server.
ematipico
approved these changes
Apr 4, 2023
bluwy
approved these changes
Apr 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
decodeUri,encodeUriandnew URLcan all throw errors in some cases. This would crash the server completely in certain cases.I checked how Express and other servers handle this, and most of them just try catch it, so figured we can do the same.
Fix #6736
Testing
Added a test
Docs
N/A