Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check): Dynamically import check command #6717

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

Princesseuh
Copy link
Member

Changes

In a past PR, we changed all the imports to other commands to be dynamically imported so the overall CLI run faster. There's still quite a bit of improvements to be made there, but still, it helped a lot.

A previous PR added check back as a normal import, so this PR fixes this.

Testing

Tests still pass and tested manually!

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

🦋 Changeset detected

Latest commit: 38dc1e5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 31, 2023
@Princesseuh Princesseuh merged commit c2d4ae1 into main Mar 31, 2023
@Princesseuh Princesseuh deleted the fix/dynamic-import-check branch March 31, 2023 13:18
@astrobot-houston astrobot-houston mentioned this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants