[create-astro] Error on --template that does not exist
#6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c13d428.
🦋 Changeset detectedLatest commit: 5a5c68c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
bholmesdev
commented
Mar 27, 2023
| @@ -81,11 +86,18 @@ export default async function copyTemplate(tmpl: string, ctx: Context) { | |||
| } catch (err: any) { | |||
| fs.rmdirSync(ctx.cwd); | |||
| if (err.message.includes('404')) { | |||
| await error('Error', `Template ${color.reset(tmpl)} ${color.dim('does not exist!')}`); | |||
| throw new Error(`Template ${color.reset(tmpl)} ${color.dim('does not exist!')}`); | |||
There was a problem hiding this comment.
This used to log the error and close the spinner before ctx.exit could be called. This throws so the higher scope can catch and log appropriately.
bluwy
approved these changes
Mar 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c13d428.
Changes
Testing
N/A - dry run prevents actually fetching to avoid flakiness
Docs
N/A