fix(tsconfig): Update tsconfig templates to ignore 5.0 deprecations #6605
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc0f626 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
approved these changes
Mar 20, 2023
ematipico
approved these changes
Mar 20, 2023
Merged
michalbundyra
added a commit
to michalbundyra/create-t3-app
that referenced
this pull request
Mar 23, 2023
3 tasks
juliusmarminge
pushed a commit
to t3-oss/create-t3-app
that referenced
this pull request
Mar 23, 2023
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
monstar911
added a commit
to monstar911/create-t3-app
that referenced
this pull request
Mar 25, 2023
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
Virusold0607
added a commit
to Virusold0607/create-t3-app
that referenced
this pull request
Apr 10, 2023
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
NikolaRadun
added a commit
to NikolaRadun/create-t3-app
that referenced
this pull request
Mar 24, 2024
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
KevSoftCode
added a commit
to KevSoftCode/create-t3-app
that referenced
this pull request
May 14, 2024
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
korawit-dvtx
pushed a commit
to korawit-dvtx/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
colincode7
added a commit
to colincode7/create-t3-app
that referenced
this pull request
Jun 12, 2024
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
risingstar0225
added a commit
to risingstar0225/t3-app
that referenced
this pull request
Jul 24, 2024
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
aguru320
added a commit
to aguru320/t3-app
that referenced
this pull request
Aug 2, 2024
* chore: bump typescript - 5.0.2 * adds changeset * remove deprecated importsNotUsedAsValues * set verbatimModuleSyntax flag * update versions * update deps, still waiting for type-fest to be released * update deps - with type-fest 3.7.0 * revert changes in www tsconfig - due to changes in astro - see: withastro/astro#6605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TS 5.0 deprecated
importsNotUsedAsValues, which we use in our strict tsconfig template. Unfortunately, we can't migrate to the new optionverbatimModuleSyntaxuntil a majority of our users are on TS 5.0+ because the option is incompatible withisolatedModules, which we also use (having both is redundant together, that's why they're incompatible)So, we'll just ignore the deprecations for a few TS version and upgrade our templates then. Once VS Code ships TS 5.0 (in a month or so), a big part of our users will be on TS 5.0 already, so shouldn't take long
Close #6599
Testing
Tested manually
Docs
N/A